[SERVER-79607] ShardRegistry shutdown should not wait indefinitely on outstanding network requests Created: 02/Aug/23 Updated: 29/Oct/23 Resolved: 14/Aug/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0, 7.0.1, 6.0.10 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Allison Easton | Assignee: | Allison Easton |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Sharding EMEA
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v7.0, v6.0
|
||||||||
| Sprint: | Sharding EMEA 2023-08-07, Sharding EMEA 2023-08-21 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 120 | ||||||||
| Description |
|
There is a detailed description in the last comment of the BF linked. Summary: When we shutdown the shard registry, we shut down and join the thread pool used by the shard registry. Shutting down the thread pool just changes the state to be joinRequired. This stops any new tasks from being scheduled, but requires the join to still wait for all ongoing tasks to complete without interrupting them. In the case shown in the BF, one of the outgoing requests never finished, thus causing the join to stall. Some options to fix this:
|
| Comments |
| Comment by Githook User [ 22/Aug/23 ] |
|
Author: {'name': 'Allison Easton', 'email': 'allison.easton@mongodb.com', 'username': 'allisoneaston'}Message: (cherry picked from commit cce7e48a789e973cb647639f4d482d64c1c87b23) |
| Comment by Githook User [ 22/Aug/23 ] |
|
Author: {'name': 'Allison Easton', 'email': 'allison.easton@mongodb.com', 'username': 'allisoneaston'}Message: (cherry picked from commit cce7e48a789e973cb647639f4d482d64c1c87b23) |
| Comment by Githook User [ 14/Aug/23 ] |
|
Author: {'name': 'Allison Easton', 'email': 'allison.easton@mongodb.com', 'username': 'allisoneaston'}Message: |