[SERVER-79869] The WiredTiger event handler is not used correctly when calling compact Created: 09/Aug/23 Updated: 29/Oct/23 Resolved: 10/Aug/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Etienne Petrel | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Operating System: | ALL | ||||||||||||||||
| Steps To Reproduce: | Include |
||||||||||||||||
| Sprint: | Execution NAMR Team 2023-08-21 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
The WiredTiger team tried to perform a drop yesterday, see the patch build which contains failures related to compact testing in MDB. When compaction is performed, we check periodically if it has been interrupted by the application or if the timeout (if configured) has elapsed, see here. With To know whether compaction has been interrupted by the application, we check the event handler. There was some work done related to this through
The session->app_private field is set only if a SessionDataRAII is constructed and used for the compact operation, which is the case here. However, there is another call to compact in the MDB layer such as in wiredtiger_util_test.cpp that is not using the SessionDataRAII so when the event handler is checked, it crashes with the invariant. There might be other calls to compact that would lead to the issue. After checking why it was not failing prior to The suggested code changes are the following ones:
|
| Comments |
| Comment by Githook User [ 10/Aug/23 ] |
|
Author: {'name': 'Etienne Petrel', 'email': 'etienne.petrel@mongodb.com', 'username': 'etienneptl'}Message: |
| Comment by Etienne Petrel [ 09/Aug/23 ] |
|
benety.goh@mongodb.com, gregory.wlodarek@mongodb.com, can you have a look, please? It is blocking the WiredTiger drop and we would like not to revert the code changes as they are correct. If you are not convinced with the suggested solution, I am happy to discuss more and if we can disable the failing tests temporarily, it could be great too! Thank you. |