[SERVER-79899] Add comments to explain setSystemOperationUnkillableByStepdown Created: 10/Aug/23 Updated: 29/Oct/23 Resolved: 08/Sep/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.2.0-rc0 |
| Type: | Improvement | Priority: | Trivial - P5 |
| Reporter: | Jiawei Yang | Assignee: | Jiawei Yang |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Replication
|
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Repl 2023-09-04, Repl 2023-09-18 |
| Participants: |
| Description |
|
The function name setSystemOperationUnkillableByStepdown is not clearly expressing the exact case of killOp during stepdown. Like, the thread won't be interrupted during stepdown if it doesn't hold any global lock. We should add more comments around setSystemOperationUnkillableByStepdown so people who want to use it can make the right choice. We'd better provide suggestions on when a thread is interrupted by stepdown, how should the upper layer handle it. |
| Comments |
| Comment by Githook User [ 08/Sep/23 ] |
|
Author: {'name': 'Jiawei Yang', 'email': 'jiawei.yang@mongodb.com', 'username': 'YoungYang0820'}Message: |