[SERVER-79982] Batched catalog writers can run concurrently with HistoricalCatalogIdTracker::cleanup() and lead to incorrect PIT find results. Created: 14/Aug/23 Updated: 15/Dec/23 Resolved: 08/Sep/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.2.0-rc0, 7.0.2, 7.1.0-rc2, 6.0.13, 5.0.24 |
| Type: | Bug | Priority: | Critical - P2 |
| Reporter: | Suganthi Mani | Assignee: | Jordi Olivares Provencio |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | auto-reverted | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Storage Execution EMEA
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v7.1, v7.0, v6.0, v5.0
|
||||||||
| Sprint: | Execution EMEA Team 2023-09-18 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 167 | ||||||||
| Description |
|
This comment here is incorrect. Timestamp monitor doesn't take global lock while callbacks are executed. This means we can have concurrent batched catalog writers during HistoricalCatalogIdTracker::cleanup() and can result in below bugs- 1) server crash due to this invariant failure 2) more serious data inconsistency bug - Find command returning incorrect results when the sequence is as follows: 1) HistoricalCatalogIdTracker::cleanup() makes a copy of _nss |
| Comments |
| Comment by Githook User [ 15/Dec/23 ] |
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: GitOrigin-RevId: 8bd81c2b26b0cddcabcfde059ac66344d7844383 |
| Comment by Githook User [ 15/Dec/23 ] |
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: GitOrigin-RevId: 4a3fd232233a59e087f8d7376af573b944926161 |
| Comment by Githook User [ 08/Sep/23 ] |
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: |
| Comment by Githook User [ 08/Sep/23 ] |
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: |
| Comment by Githook User [ 08/Sep/23 ] |
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: |
| Comment by Githook User [ 08/Sep/23 ] |
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: Revert " This reverts commit d77c09cef3847855c6d12b8abfd909a85a2105b5. |
| Comment by Githook User [ 08/Sep/23 ] |
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: Revert " This reverts commit f9e5c019fb4f0f588a21836780d6cc510b0a90c7. |
| Comment by xgen-buildbaron-user [ 07/Sep/23 ] |
|
Ticket re-opened due to revert. benchmarks_orphaned_second_half began a consistent failure of build/install/bin/collection_catalog_bm |
| Comment by Githook User [ 07/Sep/23 ] |
|
Author: {'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com', 'username': ''}Message: Revert " This reverts commit 3338e138622314b119bfa11ca68fbf1d98430f4f. |
| Comment by Githook User [ 06/Sep/23 ] |
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: |
| Comment by Githook User [ 06/Sep/23 ] |
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: |
| Comment by Githook User [ 06/Sep/23 ] |
|
Author: {'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}Message: |
| Comment by Jordi Olivares Provencio [ 04/Sep/23 ] |
|
As this code was introduced in 6.2 I'm requesting a backport to 7.0 and 7.1 |