[SERVER-80123] Enable background compaction by default in appropriate test suites Created: 16/Aug/23 Updated: 07/Feb/24 |
|
| Status: | Open |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Gregory Wlodarek | Assignee: | Backlog - Storage Execution Team |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||
| Assigned Teams: |
Storage Execution
|
||||||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||||||
| Sprint: | StorEng - Defined Pipeline, 2023-12-12 - Heisenbug | ||||||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||||||
| Linked BF Score: | 154 | ||||||||||||||||||||||||||||||||||||||||
| Story Points: | 3 | ||||||||||||||||||||||||||||||||||||||||
| Description |
|
Part of the work will be determining which suites would be appropriate for this. Perhaps the concurrency suite? This will help identify any issues over the long term with background compaction. |
| Comments |
| Comment by Etienne Petrel [ 09/Jan/24 ] | |||||||||||||||||||||||||||
|
Before enabling background compaction by default, we want to make sure it is safe to do so. | |||||||||||||||||||||||||||
| Comment by Githook User [ 15/Dec/23 ] | |||||||||||||||||||||||||||
|
Author: {'name': 'Etienne Petrel', 'email': 'etienne.petrel@mongodb.com', 'username': 'etienneptl'}Message: Revert "SERVER-80123 Enable background compaction in suites/core.yml" This reverts commit 1d5fdb4ae9459a2852132d9db4a558d27bca322a. GitOrigin-RevId: 2dfe5e03f4f1d50020225e0cff0c198a3b6ef309 | |||||||||||||||||||||||||||
| Comment by Githook User [ 13/Dec/23 ] | |||||||||||||||||||||||||||
|
Author: {'name': 'Etienne Petrel', 'email': 'etienne.petrel@mongodb.com', 'username': 'etienneptl'}Message: SERVER-80123 Enable background compaction in suites/core.yml GitOrigin-RevId: 1d5fdb4ae9459a2852132d9db4a558d27bca322a | |||||||||||||||||||||||||||
| Comment by Etienne Petrel [ 13/Dec/23 ] | |||||||||||||||||||||||||||
|
After several patch builds, it seems that the suites/core.yml is suitable to have background compaction enabled by default. | |||||||||||||||||||||||||||
| Comment by Etienne Petrel [ 13/Dec/23 ] | |||||||||||||||||||||||||||
Thank you, created
It could be, nonetheless, I don't see how background compaction is involved. | |||||||||||||||||||||||||||
| Comment by Gregory Wlodarek [ 07/Dec/23 ] | |||||||||||||||||||||||||||
|
Yes etienne.petrel@mongodb.com, we should take the IX global lock there. Nice catch. | |||||||||||||||||||||||||||
| Comment by Etienne Petrel [ 07/Dec/23 ] | |||||||||||||||||||||||||||
|
Created a patch build enabling background compaction in the aforementioned suites and they fail here:
When we call autoCompact from notifyStartupComplete, we don't hold the IX lock, should we, gregory.wlodarek@mongodb.com? I am thinking of the following:
| |||||||||||||||||||||||||||
| Comment by Etienne Petrel [ 06/Dec/23 ] | |||||||||||||||||||||||||||
|
Potential suites: https://github.com/mongodb/mongo/blob/master/buildscripts/resmokeconfig/suites/replica_sets_jscore_passthrough.yml | |||||||||||||||||||||||||||
| Comment by Etienne Petrel [ 29/Nov/23 ] | |||||||||||||||||||||||||||
|
After a discussion with gregory.wlodarek@mongodb.com on Slack, here is what we can do:
This work will be done in a separate ticket: | |||||||||||||||||||||||||||
| Comment by Etienne Petrel [ 29/Nov/23 ] | |||||||||||||||||||||||||||
|
gregory.wlodarek@mongodb.com, in |