[SERVER-80376] Remove cluster_commands_helpers' isShardedColl method Created: 24/Aug/23  Updated: 29/Oct/23  Resolved: 29/Aug/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Jordi Serra Torrens Assignee: Miquel Munoz (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
is caused by SERVER-78611 createIndexes, dropindexes and valida... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution EMEA Team 2023-09-04
Participants:
Linked BF Score: 120

 Description   

SERVER-78611 added an isShardedColl method to cluster_commands_helpers, which queries the configsvr metadata.

This method has very deceiving stability guarantees and will very likely be misused.
The original usage on collmod_coordinator was right in using it because it does have stability guarantees due to it being a ddl coordinator that is holding the DDL lock.
The new usages on cluster_* commands do not have that stability. Also, given that those are router commands, which operate on a routing table, it is not necessary to use isShardedColl to figure out if the collection was sharded – the routing table itself already has that information.



 Comments   
Comment by Githook User [ 29/Aug/23 ]

Author:

{'name': 'Miquel Munoz', 'email': 'miquelmunozz@gmail.com', 'username': 'mimugara'}

Message: SERVER-80376 Change cluster_commands_helpers' isShardedColl method
Branch: master
https://github.com/mongodb/mongo/commit/c85e4d5edbf379f4ed63c883243302bc6c0d5f29

Generated at Thu Feb 08 06:43:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.