[SERVER-80482] collectionClonerExecutor should shutdown properly when interrupted Created: 28/Aug/23  Updated: 29/Oct/23  Resolved: 14/Sep/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.2.0-rc0

Type: Bug Priority: Major - P3
Reporter: Kruti Shah Assignee: Jiawei Yang
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Related
Assigned Teams:
Sharding NYC
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v7.1
Sprint: Repl 2023-09-04, Repl 2023-09-18
Participants:
Linked BF Score: 135

 Description   

The attached BF shows occurrences where the reshardingRecipientService is not fully shutting down when shudown is called on the donor node.

While the service is being shut down, it calls shutdown on an object called dataReplication. Data Replication proceeds to shuts down the oplogFetcherExecutor here but fails to shutdown the collectionClonerExecutor, which I believe is causing the shutdown to hang. 



 Comments   
Comment by Githook User [ 14/Sep/23 ]

Author:

{'name': 'Jiawei Yang', 'email': 'jiawei.yang@mongodb.com', 'username': 'YoungYang0820'}

Message: SERVER-80482 shutdown resharding collectionClonerExecutor properly
Branch: master
https://github.com/mongodb/mongo/commit/e16eb93d182ae1f28c68ab84a5cbba7ada7bc3b4

Comment by Kelsey Schubert [ 07/Sep/23 ]

Great, thanks for the clarification. I'll update the BF's metadata accordingly.

Comment by Jiawei Yang [ 07/Sep/23 ]

kelsey.schubert@mongodb.com The change hasn't been merged since there is something I need to fix to make it work. The commit queue merge task has been removed so it didn't go in. I'm still trying to fix this but it's not as easy as I expected. 

Regarding 7.1, the feature flag covering this code has not been enabled on 7.1 so this BF should only happen in all feature flags suites. I will fix this BF first if we enable the feature flag on 7.1 but most likely we won't enable the feature flag.

Comment by Kelsey Schubert [ 07/Sep/23 ]

jiawei.yang@mongodb.com, I think this ticket can be resolved since the change has been merged? (I'm not sure why there isn't a comment from the githook, maybe github had a problem). Would you please backport the change to 7.1 by next week?

Thanks!

Generated at Thu Feb 08 06:43:40 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.