[SERVER-80526] Refactor appendFieldsForStartTransaction Created: 29/Aug/23 Updated: 12/Dec/23 |
|
| Status: | Backlog |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Randolph Tan | Assignee: | Backlog - Cluster Scalability |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | sharding-nyc-tech-debt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Cluster Scalability
|
||||||||
| Participants: | |||||||||
| Description |
|
This code re-checks that the input cmdObj is in sync with the parsed readConcernArgs (i.e., that we didn't swap majority for local or snapshot somewhere along the command execution path). This is very error prone and wasteful and a better architecture would be if cmdObj was not allowed to contain any read concern arguments so that we can just append the ones passed to the function. |