[SERVER-80526] Refactor appendFieldsForStartTransaction Created: 29/Aug/23  Updated: 12/Dec/23

Status: Backlog
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Randolph Tan Assignee: Backlog - Cluster Scalability
Resolution: Unresolved Votes: 0
Labels: sharding-nyc-tech-debt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-77506 Sharded multi-document transactions c... Closed
Assigned Teams:
Cluster Scalability
Participants:

 Description   

This code re-checks that the input cmdObj is in sync with the parsed readConcernArgs (i.e., that we didn't swap majority for local or snapshot somewhere along the command execution path). This is very error prone and wasteful and a better architecture would be if cmdObj was not allowed to contain any read concern arguments so that we can just append the ones passed to the function.

https://github.com/10gen/mongo/blob/e3d867d884892e7e59c50704e3eee1f81c55ccd5/src/mongo/s/transaction_router.h#L759


Generated at Thu Feb 08 06:43:47 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.