[SERVER-80597] Ensure query settings are present on mongos before removing them in query_settings_cmds_validation.js Created: 31/Aug/23  Updated: 29/Oct/23  Resolved: 04/Sep/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.2.0-rc0

Type: Task Priority: Major - P3
Reporter: Denis Grebennicov Assignee: Denis Grebennicov
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
Backwards Compatibility: Fully Compatible
Sprint: QE 2023-09-04, QE 2023-09-18
Participants:
Linked BF Score: 154

 Comments   
Comment by Githook User [ 04/Sep/23 ]

Author:

{'name': 'Denis Grebennicov', 'email': 'denis.grebennicov@mongodb.com', 'username': 'denis631'}

Message: SERVER-80597 Ensure query settings are present on mongos before removing them in query_settings_cmds_validation.js
Branch: master
https://github.com/mongodb/mongo/commit/5cb5ddb93de42db6e09adf807c78283b1c626258

Comment by xgen-buildbaron-user [ 02/Sep/23 ]

Ticket re-opened due to revert. query_stats_mongos_passthrough began a consistent failure of jstests\core\query\query_settings\query_settings_cmds_validation.js

Comment by Githook User [ 02/Sep/23 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com', 'username': ''}

Message: Revert "SERVER-80597 Ensure query settings are present on mongos before removing them in query_settings_cmds_validation.js"

This reverts commit 430ad347473488d6662a6607e06e309ef5a1ff34.
Branch: master
https://github.com/mongodb/mongo/commit/4f1fbb25f7924b4ca1e7623579c1cb5b5beccf25

Comment by Githook User [ 01/Sep/23 ]

Author:

{'name': 'Denis Grebennicov', 'email': 'denis.grebennicov@mongodb.com', 'username': 'denis631'}

Message: SERVER-80597 Ensure query settings are present on mongos before removing them in query_settings_cmds_validation.js

Due to timing issue it may happen that `removeAllQuerySettings()` doesn't remove
"all" query settings, because at the moment of deletion, not all of them are
present on mongos.

This patch resolves this issue, by asserting that the newly inserted query
settings are present on mongos as well as ensuring that the query settings are
no longer present upon deletion.
Branch: master
https://github.com/mongodb/mongo/commit/430ad347473488d6662a6607e06e309ef5a1ff34

Generated at Thu Feb 08 06:44:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.