[SERVER-80780] sharded_collections_single_writes_without_shard_key_jscore should enable jscore tests that do single writes without shard key Created: 05/Sep/23 Updated: 05/Feb/24 |
|
| Status: | In Progress |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Lingzhi Deng | Assignee: | Jason Zhang |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | sharding-nyc-subteam3 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Assigned Teams: |
Sharding NYC
|
||||||||||||||||
| Sprint: | Sharding NYC 2023-09-18, Sharding NYC 2023-10-02, Sharding NYC 2023-10-16, Sharding NYC 2023-10-30, Cluster Scalability 2023-11-13, Cluster Scalability 2023-11-27, Cluster Scalability 2023-12-11, Cluster Scalability 2023-12-25, Cluster Scalability 2024-1-8, Cluster Scalability 2024-1-22, Cluster Scalability 2024-2-5, Cluster Scalability 2024-2-19 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Story Points: | 1 | ||||||||||||||||
| Description |
|
Looks like |
| Comments |
| Comment by Vishnu Kaushik [ 05/Sep/23 ] | ||||
|
Ah I see, thanks for pointing that out. In that case, I think this ticket can clean up some tests that have assumes_unsharded_collection such as update2.js which seem to have it only due to the updateOne limitation:
| ||||
| Comment by Lingzhi Deng [ 05/Sep/23 ] | ||||
|
I think we may want to tag all assumes_unsharded_collection tests properly to differentiate tests that truly aren't supposed to run against a sharded collection and tests that exercise single writes w/o shard key. And we should continue to exclude the former but enable the latter. And now that the feature flag is enabled, I don't think we need two suites (sharded_collections_jscore_passthrough and sharded_collections_single_writes_without_shard_key_jscore_passthrough) and I think we can just have the sharded_collections_jscore_passthrough also enable tests that do single writes w/o shard key and get rid of the other suite. | ||||
| Comment by Vishnu Kaushik [ 05/Sep/23 ] | ||||
|
Is my understanding correct that after the feature flag for updateOne w/o shard key is removed, then there will be no need at all for the assumes_unsharded_collection tag? |