[SERVER-80797] Build scons with all cores in setup script Created: 06/Sep/23 Updated: 19/Sep/23 Resolved: 06/Sep/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Alex Neben | Assignee: | Alex Neben |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Participants: |
| Description |
|
Add a line on the workstation setup page that scons will already have been run for you. |
| Comments |
| Comment by Alex Neben [ 09/Sep/23 ] |
|
> Would it make sense/be possible to combine the two builds so that we don't need to go through the scons config + code gen + clang-tidy prep + etc 2 times (or 4 if you count both master and 7.0). Plus we might be able to use ninja + icecream to speed up those steps. |
| Comment by Mathias Stearn [ 07/Sep/23 ] |
|
Ahh, I saw it compiling stuff, not just generating sources, so I assumed something had gone wrong. But it sounds like you now need to compile some things in order to have a working compile_comands.json. Would it make sense/be possible to combine the two builds so that we don't need to go through the scons config + code gen + clang-tidy prep + etc 2 times (or 4 if you count both master and 7.0). Plus we might be able to use ninja + icecream to speed up those steps. Of course it may not be worth messing with this if the bazel transition is imminent. |
| Comment by Alex Neben [ 06/Sep/23 ] |
|
The is intended. compiledb should give you everything needed to have a working compile_commands.json which includes some generated headers, clang-tidy shared object, etc |
| Comment by Mathias Stearn [ 06/Sep/23 ] |
|
Actually, I think the bug is that it is expecting the "compiledb" task to be and not run any actual compiles, but (at least when I ran it) it seems to. https://github.com/mongodb/server-workflow-tool/blob/master/virtual_workstation_setup.sh#L161-L163 |