[SERVER-80825] Complete TODO listed in SERVER-76131 Created: 06/Sep/23  Updated: 09/Nov/23  Resolved: 09/Nov/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Task Priority: Major - P3
Reporter: PM Bot Assignee: Josef Ahmad
Resolution: Fixed Votes: 0
Labels: autogen-todo
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-76131 Move the global fsync state from the ... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution EMEA Team 2023-10-16, Execution EMEA Team 2023-10-30, CAR Team 2023-11-13
Participants:

 Description   

There is a TODO in the codebase referencing a resolved ticket which is assigned to you.

Please follow this link to see the lines of code referencing this resolved ticket:
https://github.com/mongodb/mongo/search?q=SERVER-76131&type=Code

The next steps for this ticket are to either remove the outdated TODO or follow the steps in the TODO if it is correct. If the latter, please update the summary and description of this ticket to represent the work you're actually doing.



 Comments   
Comment by Githook User [ 09/Nov/23 ]

Author:

{'name': 'Josef Ahmad', 'email': 'josef.ahmad@mongodb.com', 'username': 'josefahmad'}

Message: SERVER-80825 Remove TODO listed in SERVER-76131
Branch: master
https://github.com/mongodb/mongo/commit/9d954a8518bba6500b72ed7b1015c13cdde7ff6f

Comment by Josef Ahmad [ 08/Nov/23 ]

The TODO is about making the FSyncLockThread a decoration on the service context. This is beyond the goals stated in SERVER-76131, which is likely why we overlooked the TODO.

Making the FSyncLockThread a decoration requires redesigning it because decorations are typically set once and upfront, whilst the fsync command currently destroys and recreates the FSyncLockThread on every invocation. There isn't a compelling need for this change to justify redesigning the life cycle of the FSyncLockThread. We can certainly revisit in the future if the need arises.

Generated at Thu Feb 08 06:44:40 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.