[SERVER-80859] Reshuffle UpdateStage/DeleteStage's logic to skip restore Created: 07/Sep/23  Updated: 29/Oct/23  Resolved: 20/Sep/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.2.0-rc0, 7.1.0-rc4

Type: Task Priority: Major - P3
Reporter: Jordi Serra Torrens Assignee: Jordi Serra Torrens
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Problem/Incident
causes SERVER-82361 Update stage swallows StorageUnavaila... Closed
Related
related to SERVER-78470 Prevent multi-false UpdateStage/Delet... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v7.1
Sprint: Sharding EMEA 2023-09-18, Sharding EMEA 2023-10-02
Participants:
Linked BF Score: 130

 Description   

SERVER-78470 introduced this condition to skip restoring children stages when Update/DeleteStages are already EOF. This appears to have caused a significant performance regression on some workloads.

Performance patches have shown that restoring children unconditionally but allowing failures to restore in the cases where it is not necessary resolves the performance regression, while keeping the same semantics required for SERVER-78470.



 Comments   
Comment by Githook User [ 25/Sep/23 ]

Author:

{'name': 'Jordi Serra Torrens', 'email': 'jordi.serra-torrens@mongodb.com', 'username': 'jordist'}

Message: SERVER-80859 Reshuffle UpdateStage/DeleteStage's logic to skip restore
Branch: v7.1
https://github.com/mongodb/mongo/commit/d81bcfcd4acb35a78c91466620ec150d213dc46f

Comment by Githook User [ 19/Sep/23 ]

Author:

{'name': 'Jordi Serra Torrens', 'email': 'jordi.serra-torrens@mongodb.com', 'username': 'jordist'}

Message: SERVER-80859 Reshuffle UpdateStage/DeleteStage's logic to skip restore
Branch: master
https://github.com/mongodb/mongo/commit/bf35911f01b092c04b8060738829bf3a7a7ee776

Comment by Githook User [ 18/Sep/23 ]

Author:

{'name': 'Jordi Serra Torrens', 'email': 'jordi.serra-torrens@mongodb.com', 'username': 'jordist'}

Message: Revert "SERVER-80859 Reshuffle UpdateStage/DeleteStage's logic to skip restore"

This reverts commit 7faae75bb320dac7a143ae890be6b33a3f8e0639.
Branch: master
https://github.com/mongodb/mongo/commit/19c84d23e4a9ed23ec6d293545fbfa0ff127fa46

Comment by Githook User [ 15/Sep/23 ]

Author:

{'name': 'Jordi Serra Torrens', 'email': 'jordi.serra-torrens@mongodb.com', 'username': 'jordist'}

Message: SERVER-80859 Reshuffle UpdateStage/DeleteStage's logic to skip restore
Branch: master
https://github.com/mongodb/mongo/commit/7faae75bb320dac7a143ae890be6b33a3f8e0639

Generated at Thu Feb 08 06:44:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.