[SERVER-80898] Audit gFeatureFlagChangeStreamsFurtherEnrichedEvents Created: 08/Sep/23  Updated: 27/Oct/23  Resolved: 08/Sep/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Kyle Suarez Assignee: Arun Banala
Resolution: Gone away Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-79317 Provide more documentation and helper... Closed
Sprint: QI 2023-10-02
Participants:

 Description   

This ticket has been split from an audit of all Query 7.0 feature flags. This ticket is a request to audit gFeatureFlagChangeStreamsFurtherEnrichedEvents.

Intial sync can temporarily reset the fcv value to uninitialized and sets the new value afterwards. This can cause call sites trying to inspect the fcv value to hit this invariant. We need to audit feature flag usage and determine which should do one of the following:

  • It can never be called when initial sync is running. So do nothing. Note that this can be tricky to prove as we once thought the catalog cache loader can never be run while initial sync is happening but it can.
  • It is safe to ignore fcv version so use isEnabledAndIgnoreFCVUnsafe instead
  • It is safe to turn off the feature anytime (even if feature flag is actually on) so use isEnabledUseDefaultFCVWhenUninitialized instead.
  • Special logic is needed if fcv is not initialized


 Comments   
Comment by Kyle Suarez [ 08/Sep/23 ]

Huzzah! Thanks arun.banala@mongodb.com. Yes, let's close this as gone away.

Comment by Arun Banala [ 08/Sep/23 ]

kyle.suarez@mongodb.com We removed this feature flag already as part of SERVER-67387. Is it fine to close this ticket?

Comment by Kyle Suarez [ 08/Sep/23 ]

arun.banala@mongodb.com would you mind please taking this one, since you were driving much of this project? If you don't have bandwidth please let me know and I'll ask another member of the team.

Generated at Thu Feb 08 06:44:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.