[SERVER-80910] Remove TimestampMonitor::clearListeners Created: 08/Sep/23  Updated: 26/Oct/23

Status: Backlog
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Jordi Olivares Provencio Assignee: Backlog - Storage Execution Team
Resolution: Unresolved Votes: 0
Labels: former-storex-namer, neweng, techdebt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Storage Execution
Participants:

 Description   

The code is not used at all and the few test cases that use it could be switched to use TimestampMonitor::removeListener_forTestOnly()



 Comments   
Comment by yokeshwaran vk [ 13/Sep/23 ]

Hi jordi.olivares-provencio@mongodb.com ,

Thanks for guiding me through the process. I have completed the signing of the MongoDB Contributor Agreement. I received confirmation email as well from Adobe Sign.

w.r.t ticket, I understand my task is to remove the specified code, as it is no longer necessary due to the updated functionality of the TimestampMonitor. Apart from this 1 instance u mentioned, which should be changed to use removeListener_forTestOnly(), I will make sure the rest of the references are properly removed.  Once I have made the changes, I will open a PR for review.

I look forward to contributing to MongoDB.

 

Comment by Jordi Olivares Provencio [ 12/Sep/23 ]

Hi yokesh440@yahoo.com! Thanks for volunteering on this!

There is a process external contributors must follow in order to contribute to the mongodb codebase. The full process can be found here.

In this situation you'll have to sign the Contributor's Agreement first (step 1 in the link) and then we can proceed forward with it. As you've already found this ticket, we can skip to step 3.

The purpose of the ticket here is removing the code mentioned. This code is only used in the storage_engine_test.cpp file. In most cases, it can simply be removed since destruction of the TimestampMonitor doesn't require a call to TimestampMonitor::clearListeners now.

I can only see one instance actually using it for the intended purpose and that could trivially be changed to use the removeListener_forTestOnly() method.

Comment by yokeshwaran vk [ 08/Sep/23 ]

Hi

I have reviewed this ticket, I like to work in this. I don't have permissions to assign the ticket to myself. Can someone assign this ticket to me or guide me on next steps? thanks!

CC: jordi.olivares-provencio@mongodb.com 

Generated at Thu Feb 08 06:44:55 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.