[SERVER-80944] Enable more clang-tidy rules as VSCode suggestions Created: 11/Sep/23 Updated: 18/Sep/23 Resolved: 18/Sep/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Matt Boros | Assignee: | [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive) |
| Resolution: | Won't Fix | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Server Development Platform
|
||||||||
| Participants: | |||||||||
| Description |
|
Some clang-tidy rules are too broad to enforce strictly. We should consider having a list of enforced rules (like the enabled rules today) and a list of rules that are not required but create suggestions in VSCode (example below).
|
| Comments |
| Comment by Matt Boros [ 15/Sep/23 ] |
|
That seems fair to me. The reason I filed this is because as I work on SERVER-77158, I've run into rules that seem okay to enable, but then we find a corner case that we realize makes it unsafe. So we can't enable the rule, but we want developers to still see it somehow because they're easy to forget. That's what led me to this ticket. |