[SERVER-80979] Consolidate logging checks in RecoveryUnit::_executeCommitHandlers Created: 12/Sep/23 Updated: 29/Oct/23 Resolved: 20/Oct/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.2.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Mark Benvenuto | Assignee: | Wei Hu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | perf-tiger, perf-tiger-handoff | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Storage Execution NAMER
|
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Execution Team 2023-10-30 |
| Participants: |
| Description |
|
In RecoveryUnit::_executeCommitHandlers, we call LOG2_DEBUG in two loops. This results in a small overhead to check if logging is enabled in each iteration of the loop. We should check if logging is enabled once before the loop. POC: https://github.com/10gen/mongo/commit/6e3417d8c572bbaf17b2909594b36f227937b3ef |
| Comments |
| Comment by Githook User [ 20/Oct/23 ] |
|
Author: {'name': 'Wei Hu', 'email': 'wei.hu@mongodb.com', 'username': 'wh5a'}Message: |