Ensure cluster-wide parameters mechanism correctness (when working with query settings parameter) (SERVER-78801)

[SERVER-81099] Prevent set-/removeQuerySettings being called in standalone Created: 15/Sep/23  Updated: 08/Jan/24  Resolved: 06/Jan/24

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Sub-task Priority: Major - P3
Reporter: Denis Grebennicov Assignee: Romans Kasperovics
Resolution: Fixed Votes: 0
Labels: M2
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-83439 Prohibit users calling set-/removeQue... Closed
Problem/Incident
Assigned Teams:
Query Execution
Backwards Compatibility: Fully Compatible
Sprint: QE 2023-07-24, QE 2023-08-21, QE 2023-09-04, QE 2023-09-18, QE 2023-10-02, QE 2023-10-16, QE 2023-10-30, QE 2023-11-13, QE 2023-11-27, QE 2023-12-11, QE 2023-12-25, QE 2024-01-08
Participants:
Linked BF Score: 170

 Description   

Since VectorClocks are not present on standalones, check for "lost update" problem is no longer possible.

Because this deployment is not that critical, we agreed on preventing users from calling set-/removeQuerySettings commands in standalone mongod.



 Comments   
Comment by Githook User [ 08/Jan/24 ]

Author:

{'name': 'Romans Kasperovics', 'email': 'romans.kasperovics@mongodb.com', 'username': 'romanskas'}

Message: SERVER-84622 Run index_filters_to_query_settings on replica set

SERVER-81099 prohibited query settings commands on
standalone, but this test suite was forgotten.

GitOrigin-RevId: 8ceb8ce38be5950ac826dc6a0352e85ade2e513f
Branch: master
https://github.com/mongodb/mongo/commit/5ea2dcd58ec94d27c4c62d35c5593e1589e71377

Comment by Githook User [ 06/Jan/24 ]

Author:

{'name': 'romanskas', 'email': '30618745+romanskas@users.noreply.github.com', 'username': 'romanskas'}

Message: SERVER-81099 Ban setQuerySettings on standalone (#17559)

SERVER-81099 Ban setQuerySettings on standalone

SERVER-78801 introduced checks for lost updates prohibiting concurrent
modification of query settings. These checks rely on a vector clock,
which is
not functioning correctly in standalone deployment resulting in an
internal
error. Therefore, we prohibit query settings modification on standalone.

GitOrigin-RevId: 873c971a9b8c384943ac89c43a73c7da8b4a0fb1
Branch: master
https://github.com/mongodb/mongo/commit/8934a112bed8d98cc80a4b4934d9606e734eb9ac

Generated at Thu Feb 08 06:45:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.