[SERVER-81120] Assert on Status portion of StatusWith in gRPC unit tests Created: 15/Sep/23  Updated: 27/Oct/23  Resolved: 22/Sep/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Patrick Freed Assignee: Patrick Freed
Resolution: Works as Designed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Sprint: Service Arch 2023-09-18, Service Arch 2023-10-02
Participants:
Linked BF Score: 11

 Description   

There are many instances in the gRPC unit tests where ASSERT_OK is used with StatusWith<T> objects. While this functionally works to assert that these are in fact OK, the exception that is thrown when the assertion fails does not print useful information about the error that was experienced. We should update the gRPC unit tests to invoke .getStatus() when asserting on StatusWith objects so that future BFs are more easily diagnose-able.

See BF-29927 for examples of poor log messages.



 Comments   
Comment by Patrick Freed [ 22/Sep/23 ]

Closing in favor of SERVER-81216, which fixes the issue generally.

Generated at Thu Feb 08 06:45:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.