[SERVER-81164] Reduce execution slowness of the fcv_upgrade_downgrade passthrough suites Created: 18/Sep/23 Updated: 18/Jan/24 Resolved: 18/Jan/24 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.3.0-rc0, 7.2.0-rc2 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Xuerui Fa | Assignee: | Adi Zaimi |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | sharding-nyc-subteam3 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Sharding NYC
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Backport Requested: |
v7.2
|
||||||||
| Participants: | |||||||||
| Description |
|
From a local PB, it seems the fcv_upgrade_downgrade... passthrough suites are taking a significant amount of time to complete. Looking at the JS hook, it seems we may be sleeping the thread for long durations while running the test, which will cause slowness. This is also run per test, which means that tests that previously took <1s to complete might take upwards of 20+s now. We should reduce the amount of times we run setFCV and sleep per test, and we should also avoid running the hook on every test. In mongosync passthrough testing, we would execute the hook only once every n=15 or n=20 tests, which would lead to the same test coverage over time assuming randomness in test order. |
| Comments |
| Comment by Adi Zaimi [ 18/Jan/24 ] |
|
Hook running in background was corrected to not sleep for extensive interval. |
| Comment by Adi Zaimi [ 21/Nov/23 ] |
|
Yes I agree with judah.schvimer@mongodb.com that this is a test only and should not block 7.2, however I already merged the fix for this to 7.2 branch so either way we should be good. |
| Comment by Githook User [ 20/Nov/23 ] |
|
Author: {'name': 'Adi Zaimi', 'email': 'adizaimi@yahoo.com', 'username': 'adizaimi'}Message: Reduce the duration of sleep() in the run_fcv_upgrade_downgrade_background.js background hook, |
| Comment by Adi Zaimi [ 13/Nov/23 ] |
|
FTR, I did look at ways of having the python script better control the js hook: |
| Comment by Adi Zaimi [ 13/Nov/23 ] |
|
I changed the sleep duration to be 1s (instead of 5s) so each test will now take a lot less time than before, and cumulative time is roughly similar to the duration of similar suites without the fcv upgrade downgrade hook: |
| Comment by Githook User [ 10/Nov/23 ] |
|
Author: {'name': 'Adi Zaimi', 'email': 'adizaimi@yahoo.com', 'username': 'adizaimi'}Message: Reduce the duration of sleep() in the run_fcv_upgrade_downgrade_background.js background hook, |