[SERVER-81232] Skip RSTL lock acquisition in TimestampMonitor calls Created: 20/Sep/23  Updated: 29/Oct/23  Resolved: 21/Sep/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.2.0-rc0, 7.0.3

Type: Improvement Priority: Major - P3
Reporter: Jordi Olivares Provencio Assignee: Jordi Olivares Provencio
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Backport Requested:
v7.1, v7.0
Sprint: Execution EMEA Team 2023-10-02
Participants:
Linked BF Score: 128

 Description   

The TimestampMonitor currently drops idents after the oldest timestamp has advanced. To do so it acquires the global lock + the default hierarchy. This includes the RSTL.

In some situations, the ident drop operation can take a while, blocking stepdown since it requires the RSTL in MODE_X.

As the operation does not require the RSTL we should explore skipping its acquisition since it will unnecessarily be blocking stepdown.



 Comments   
Comment by Githook User [ 05/Oct/23 ]

Author:

{'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}

Message: SERVER-81232 Skip unnecessary locks for timestamp monitor
Branch: v7.0
https://github.com/mongodb/mongo/commit/9281dbdb865d53f67c663861c773a938993cdfb0

Comment by Louis Williams [ 25/Sep/23 ]

jordi.olivares-provencio@mongodb.com I believe this is covered by SERVER-81318 already

Comment by Githook User [ 21/Sep/23 ]

Author:

{'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}

Message: SERVER-81232 Skip unnecessary locks for timestamp monitor
Branch: master
https://github.com/mongodb/mongo/commit/b4400f93a46f38c25b75ffd55a2132855bcf420f

Generated at Thu Feb 08 06:45:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.