[SERVER-81254] Prevent concurrent enablement of feature flags while upgrading FCVs after branch cut Created: 20/Sep/23 Updated: 08/Jan/24 Resolved: 08/Jan/24 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.3.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Xuerui Fa | Assignee: | Xuerui Fa |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Replication
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Backport Requested: |
v7.2
|
||||||||
| Sprint: | Repl 2023-10-02, Repl 2023-10-16, Repl 2023-10-30, Repl 2023-11-13, Repl 2023-11-27, Repl 2024-01-08 | ||||||||
| Participants: | |||||||||
| Description |
|
While I was investigating the redness from the FCV upgrade to 7.2,
This caused a significant amount of redness since tests for that feature flag were essentially enabled for clusters with FCV >= 7.1. However, the future git tag variant has lastContinuous = 7.1, and it attempted to get the 7.1 binary by pulling from evergreen. This binary is obtained from the v7.1 branch, which did not yet have the feature flag enabled. As a result, all tests relevant to that feature flag were failing.
This should not be an issue if rapid releases were working as expected and the FCV upgrade happens soon after branch cut. But if anything goes wrong again in the future, we could run into a similar issue. As a result, we should block any new feature flags from being enabled between branch cut and upgrading FCV constants. This may not be worthwhile to enforce programmatically, but we should consider adding this to the feature flag ReadMe. |
| Comments |
| Comment by Githook User [ 08/Jan/24 ] |
|
Author: {'name': 'Xuerui Fa', 'email': 'xuerui.fa@mongodb.com', 'username': 'XueruiFa'}Message: GitOrigin-RevId: e936f74d4ccd4fa6df94344db0744f34e7704f6a |