[SERVER-81422] Binding of MatchExpression parameters to SBE Runtime Environment Created: 25/Sep/23 Updated: 27/Nov/23 Resolved: 27/Oct/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.2.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Lynne Wang | Assignee: | Lynne Wang |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | QO 2023-10-02, QO 2023-10-16, QO 2023-10-30, QO 2023-11-13 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
During the binding process, we will look up the SBE slot for each parameter and bind the corresponding constant to that SBE slot. |
| Comments |
| Comment by Githook User [ 16/Oct/23 ] |
|
Author: {'name': 'Lynne Wang', 'email': 'lynne.wang@mongodb.com', 'username': 'lynne-wang'}Message: Removed simplifyDNFIntervals, aadded tryBonsai to basic_find Cleaned up debugging CMRemoved SimplifyDNFIntervals fix and replaced with change to cmp3w on different types in vm.h to enable optimizer plan selection in basic_find.h, no parameterization Updated typetag of getParam parameterized constant in MatchExpressionVisitor Updated parameterized_find jstest to verify that unsupported queries in M2 (on indexed collections) aren't parameterized or optimized Enabled input_params::bind only if CanonicalQuery not null in makeExecFromParams Removed debugging statements Refactored parameterized_find asserts Added initial logic for binding MatchExpressions in agg pipeline E2E binding of constants for parameterized agg pipelines a+ testing Added clang formatting Reverted file in rebase Fixed use after free error for pipelineMatchExpr Put binding tests behind false flag Added clang formatting Reverted untouched file |
| Comment by Lynne Wang [ 09/Oct/23 ] |
|
Before we bind parameterized constants for MatchExpressions in agg pipelines, we need to parameterize agg pipelines. |