[SERVER-81512] Remove "using namespace fmt..literals" directives from namespace scopes in headers Created: 27/Sep/23  Updated: 29/Nov/23  Resolved: 29/Nov/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Vinod Kumar
Resolution: Fixed Votes: 0
Labels: auto-reverted, neweng, techdebt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Assigned Teams:
Service Arch
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2023-11-13, Service Arch 2023-11-27, Service Arch 2023-12-11
Participants:
Linked BF Score: 135

 Description   

That is:

using namespace fmt::literals;

These have crept into 5 headers in our codebase and should come out. 
I suspect other code is depending on them.

 

 



 Comments   
Comment by Vinod Kumar [ 29/Nov/23 ]

dziana.hurynovich@mongodb.com  – Please note this can't cause regression. This is a non functional change.

Comment by Vinod Kumar [ 29/Nov/23 ]

Cleaned up the namespace.

Comment by Githook User [ 26/Nov/23 ]

Author:

{'name': 'Vinod Kumar', 'email': 'vinod.kumar@mongodb.com', 'username': 'vkumar-mdb'}

Message: SERVER-81512 Removed using namespace fmt::literals from global namespace
Branch: master
https://github.com/mongodb/mongo/commit/f064fc8dc8dc023d4105fab4d001a98a08c5c80c

Comment by Githook User [ 21/Nov/23 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com', 'username': ''}

Message: Revert "SERVER-81512 Removed using namespace fmt::literals from global namespace"

This reverts commit 3f63faa6c3787857f3c0eeeecc286e96265ca758.
Branch: master
https://github.com/mongodb/mongo/commit/68864936696008c0005e139dfd9f84b3a6061610

Comment by Githook User [ 21/Nov/23 ]

Author:

{'name': 'Vinod Kumar', 'email': 'vinod.kumar@mongodb.com', 'username': 'vkumar-mdb'}

Message: SERVER-81512 Removed using namespace fmt::literals from global namespace
Branch: master
https://github.com/mongodb/mongo/commit/3f63faa6c3787857f3c0eeeecc286e96265ca758

Generated at Thu Feb 08 06:46:42 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.