[SERVER-81602] Remove support for formatMsg from LOGV2 Created: 30/Sep/23  Updated: 29/Oct/23  Resolved: 04/Oct/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.2.0-rc0

Type: Bug Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-53936 Architecture Guide updates for Remove... Closed
is depended on by SERVER-81834 LOGV2 Remove vestigial inert fmt-mess... Backlog
is depended on by SERVER-47203 LOGV2 macros should protect against f... Closed
Duplicate
Assigned Teams:
Service Arch
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Service Arch 2023-10-16
Participants:

 Comments   
Comment by Githook User [ 04/Oct/23 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-81602 remove fmtMessage from LOGV2 statements

SERVER-80602 codebase-wide changes

remove selection test

apply clang-format

remove mistake files

remove format message

remove blank line artifacts

apply clang-format

remove blanks

SERVER-81602 logging.md update

manual fixup

windows fix

windows fix

mac fix

mac fix

add note to logging.md about legacy fmt strings
Branch: master
https://github.com/mongodb/mongo/commit/d1e66593694206bbf4d12ddae309e99d0feb9010

Comment by Billy Donahue [ 02/Oct/23 ]

This was structured as a project but I don't think it would be more than a sprint worth of work to write a script to find and remove the redundant format messages. It doesn't have to be perfect. Just a 90% solution.

The edge cases, if there are any, can be handled manually. They'll be obvious when we remove the doLog overloads that accept formatMsg and compiles fail.

(Actually it was a good Python weekend project)

Generated at Thu Feb 08 06:46:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.