[SERVER-8199] Rename text search $projection argument to $project Created: 16/Jan/13  Updated: 20/Mar/13  Resolved: 17/Jan/13

Status: Closed
Project: Core Server
Component/s: Text Search
Affects Version/s: 2.3.2
Fix Version/s: 2.4.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Tyler Brock Assignee: J Rassi
Resolution: Done Votes: 6
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-8293 FTS: projection => project to make co... Closed
Participants:

 Description   

Self explanatory:

1) We have $project everywhere in our api and $projection nowhere.
2) Projection is not a command verb like everything else in the parameters hash (search, limit, filter, etc...)



 Comments   
Comment by auto [ 17/Jan/13 ]

Author:

{u'date': u'2013-01-17T21:29:36Z', u'email': u'rassi@10gen.com', u'name': u'Jason Rassi'}

Message: SERVER-8199 Rename text search $projection argument to $project
Branch: master
https://github.com/mongodb/mongo/commit/6ac6cc7204c7b3c44aa35ba399823f15b8d80cbd

Comment by Aaron Heckmann [ 16/Jan/13 ]

The exposed API users code against should be consistent. We already defined this action as $project in the aggregation framework. Using two terms for the same action is confusing.

Comment by Tyler Brock [ 16/Jan/13 ]

Also I can't shake feeling that $project is the action being performed here and $projection is the result.

Comment by Tyler Brock [ 16/Jan/13 ]

Outside of the core read operations it's nowhere.

Aggregation, for example, uses $project and this should be the same given it is a command as well.

Comment by Scott Hernandez (Inactive) [ 16/Jan/13 ]

We do use projection in places: http://docs.mongodb.org/manual/core/read-operations/#projection, http://docs.mongodb.org/manual/reference/projection/slice/, http://docs.mongodb.org/manual/reference/method/db.collection.find/

We use this for find, as the resulting projection we want to return to the client and other places (slice). It is a projection of the source docs.

Not sure we should change it, but if we do there are more places.

Generated at Thu Feb 08 03:16:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.