[SERVER-82111] In sharded_agg_helpers.cpp move invariant below response status check Created: 12/Oct/23  Updated: 25/Jan/24  Resolved: 13/Oct/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.2.0-rc0, 7.0.5, 6.0.13, 5.0.24, 4.4.28

Type: Bug Priority: Major - P3
Reporter: Ivan Fefer Assignee: Ivan Fefer
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v7.0, v6.0, v5.0, v4.4
Sprint: QE 2023-10-16
Participants:
Case:
Linked BF Score: 135

 Description   

In sharded_agg_helpers.cpp when parsing explain results from remote shards, we first have an invariant that response have host and port and only after we check response status.

However, in some tricky network failures host and port may not be set, so we need to first check response status and after assert stuff.



 Comments   
Comment by Githook User [ 27/Dec/23 ]

Author:

{'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}

Message: SERVER-82111 In sharded explain, check invariants only if remote response status is ok

GitOrigin-RevId: 9d3acd628782dfa045a1f67313e635d958d4b8a6
Branch: v6.0
https://github.com/mongodb/mongo/commit/c6dd04f0b9501ea59165ecfac8cc0aa5ef663baf

Comment by Githook User [ 27/Dec/23 ]

Author:

{'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}

Message: SERVER-82111 In sharded explain, check invariants only if remote response status is ok

GitOrigin-RevId: 54ac53de5fee0f396246b37282e44bb28b938a3d
Branch: v4.4
https://github.com/mongodb/mongo/commit/8b21e3264e8488e577ebe235cc376504885f2a24

Comment by Githook User [ 27/Dec/23 ]

Author:

{'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}

Message: SERVER-82111 In sharded explain, check invariants only if remote response status is ok

GitOrigin-RevId: ed0b8754e5f83d13b6664398557a8030483d3271
Branch: v5.0
https://github.com/mongodb/mongo/commit/fedc1d9bad016a9adaf8950aa037ad9e707b22c6

Comment by Githook User [ 05/Dec/23 ]

Author:

{'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}

Message: SERVER-82111 In sharded explain, check invariants only if remote response status is ok

GitOrigin-RevId: 015fdfa76d9c3959e58c0000387e84abbc5bee35
Branch: v7.0
https://github.com/mongodb/mongo/commit/4a94b20e7d4b6b97aa6ec7dd22115abba0d0f1e5

Comment by Githook User [ 13/Oct/23 ]

Author:

{'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}

Message: SERVER-82111 In sharded explain, check invariants only if remote response status is ok
Branch: master
https://github.com/mongodb/mongo/commit/9de5fae86fc4ace654415d2d66f914d6828b2e21

Generated at Thu Feb 08 06:48:17 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.