[SERVER-82111] In sharded_agg_helpers.cpp move invariant below response status check Created: 12/Oct/23 Updated: 25/Jan/24 Resolved: 13/Oct/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.2.0-rc0, 7.0.5, 6.0.13, 5.0.24, 4.4.28 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Ivan Fefer | Assignee: | Ivan Fefer |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v7.0, v6.0, v5.0, v4.4
|
||||||||
| Sprint: | QE 2023-10-16 | ||||||||
| Participants: | |||||||||
| Case: | (copied to CRM) | ||||||||
| Linked BF Score: | 135 | ||||||||
| Description |
|
In sharded_agg_helpers.cpp when parsing explain results from remote shards, we first have an invariant that response have host and port and only after we check response status. However, in some tricky network failures host and port may not be set, so we need to first check response status and after assert stuff. |
| Comments |
| Comment by Githook User [ 27/Dec/23 ] |
|
Author: {'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}Message: GitOrigin-RevId: 9d3acd628782dfa045a1f67313e635d958d4b8a6 |
| Comment by Githook User [ 27/Dec/23 ] |
|
Author: {'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}Message: GitOrigin-RevId: 54ac53de5fee0f396246b37282e44bb28b938a3d |
| Comment by Githook User [ 27/Dec/23 ] |
|
Author: {'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}Message: GitOrigin-RevId: ed0b8754e5f83d13b6664398557a8030483d3271 |
| Comment by Githook User [ 05/Dec/23 ] |
|
Author: {'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}Message: GitOrigin-RevId: 015fdfa76d9c3959e58c0000387e84abbc5bee35 |
| Comment by Githook User [ 13/Oct/23 ] |
|
Author: {'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}Message: |