[SERVER-82172] Add buildifier lints to 10gen/mongodb Created: 13/Oct/23  Updated: 29/Jan/24  Resolved: 29/Jan/24

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 8.0.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Anthony Pratti Assignee: Trevor Guidry
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-81038 Self-host bazel/bazelisk/buildifier Backlog
Assigned Teams:
Build
Backwards Compatibility: Fully Compatible
Sprint: Build and Correctness OnDeck
Participants:

 Description   

Buildifier has lints, many of which have autofixes, for starlark files. It would be great to start using this in 10gen/mongodb. Currently used in mms.

See https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md.



 Comments   
Comment by Githook User [ 27/Jan/24 ]

Author:

{'name': 'Trevor', 'email': 'trevorguidry6@gmail.com', 'username': 'Trevor159'}

Message: SERVER-82172 Add buildifier lints for bazel files (#18364)

GitOrigin-RevId: d5816c1335a188ab54a22492790635b67535f3a9
Branch: master
https://github.com/mongodb/mongo/commit/948a4a507019733fe69ade524e187d23986b2a76

Comment by Anthony Pratti [ 19/Oct/23 ]

I'd recommend sticking to 6.1.x, 6.1.1 is currently used in mms and 6.1.2 is the newest patch version. 6.3 seems to have some issue with autofix no longer working, so it might cause too much friction. See https://github.com/10gen/mms/pull/84519/files#r1364419131 and https://parsley.mongodb.com/evergreen/mms_code_health_UNIT_BAZEL_LINT_FORMAT_patch_c524511577cdada1c6d0b8ded259af98c80abb3b_652ff5460ae606dd02b1b39e_23_10_18_15_10_01/0/task?bookmarks=0,493&shareLine=200 for examples of friction.

Generated at Thu Feb 08 06:48:27 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.