[SERVER-8218] Combine ClientInfo's _remote with _messagingPort->remote() Created: 17/Jan/13  Updated: 16/Sep/15  Resolved: 16/Sep/15

Status: Closed
Project: Core Server
Component/s: Internal Code, Networking, Sharding
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Spencer Brody (Inactive) Assignee: Unassigned
Resolution: Done Votes: 0
Labels: triage
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Participants:

 Description   

ClientBasic stores an AbstractMessagingPort as _messaging port. That AbstractMessagingPort has a HostAndPort that can be accessed by calling remote(). ClientBasic has a method getRemote() that returns _messagingPort->remote().

ClientBasic's subclass, ClientInfo, stores a HostAndPort as _remote directly, and overrides the getRemote() method to return _remote instead of _messagingPort->remote().

From what I can tell, however, ClientInfo's _remote always get's set to the remote() from the same AbstractMessagingPort that it is storing in _messagingPort as part of its ClientBasic data.

We should always use _messagingPort->remote(), and make getRemote in ClientBasic no longer virtual.



 Comments   
Comment by Andy Schwerin [ 16/Sep/15 ]

ClientInfo is no longer a type.

Generated at Thu Feb 08 03:16:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.