[SERVER-82268] Make sure we preserve relevant metrics for writes done via bulkWrite (timeseries) Created: 17/Oct/23  Updated: 17/Jan/24  Resolved: 17/Jan/24

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Task Priority: Major - P3
Reporter: Frederic Vitzikam Assignee: Frederic Vitzikam
Resolution: Fixed Votes: 0
Labels: milestone-1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-79610 Make sure we preserve relevant metric... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2023-11-13, Repl 2023-11-27, Repl 2023-12-11, Repl 2023-12-25, Repl 2024-01-08, Repl 2024-01-22
Participants:

 Description   

I started looking at this in SERVER-79610 but it will need a deeper look.

There are some things I found surprising with timeseries even without bulkWrite:

  • Timeseries with 1 retry seems to increment the arrayFilter metrics twice but that might be a test issue
  • document.updated is not increased on a timeseries update, neither is metrics.queryExecutor.scanned (on update or delete).
  • timeseries with retry do not increase writeConcern.update.majority, but writeConcern.update.none
  • timeseries insert does not increase writeConcern.insert.majority

On top of those bulkWrite + timeseries has its own issues:

  • Timeseries with retry and bulkWrite does not increment the arrayFilter metrics twice but that might be a test issue (unlike timeseries with retry and no bulkWrite)
  • document.updated with timeseries behaves differently between no bulkWrite (and bulkWrite with retry) and bulkWrite with no retry.
  • Timeseries with bulkWrite and retries does not increase retriedCommandsCount or retriedStatementsCount, a quick look seems it does not see a retried stmtId at all so need more investigation.

For now I stashed the changes to the test that allowed me to uncover those. I will go back to this after I finish the SERVER-79610 PRs.



 Comments   
Comment by Githook User [ 17/Jan/24 ]

Author:

{'name': 'Frederic Vitzikam', 'email': 'frederic.vitzikam@mongodb.com', 'username': 'fredvitz'}

Message: SERVER-82268 Make sure we preserve relevant metrics for writes done via bulkWrite (timeseries)

GitOrigin-RevId: 20d3596f3002ebd308375c200f89a3b136fab7c0
Branch: master
https://github.com/mongodb/mongo/commit/cb7c1bed8bc67dc9493487126e05209483df1328

Generated at Thu Feb 08 06:48:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.