[SERVER-82270] Replace isEnabledAndIgnoreFCVUnsafeAtStartup with isEnabledUseLatestFCVWhenUninitialized Created: 17/Oct/23  Updated: 15/Nov/23  Resolved: 15/Nov/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Task Priority: Major - P3
Reporter: Huayu Ouyang Assignee: Huayu Ouyang
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
depends on SERVER-79317 Provide more documentation and helper... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v7.0
Sprint: Repl 2023-11-13, Repl 2023-11-27
Participants:

 Description   

To be done after SERVER-79317. We should replace isEnabledAndIgnoreFCVUnsafeAtStartup with isEnabledUseLatestFCVWhenUninitialized since isEnabledUseLatestFCVWhenUninitialized is more accurate (for example, a binary 7.0 with 6.0 FCV, and a feature flag that is enabled on 7.0. While FCV is uninitialized during initial sync, both isEnabledAndIgnoreFCVUnsafeAtStartup and isEnabledUseLatestFCVWhenUninitialized would return true, but once the FCV is correctly set to 6.0, then isEnabledAndIgnoreFCVUnsafeAtStartup would still return true, while isEnabledUseLatestFCVWhenUninitialized would correctly return false, which is more correct since once the FCV is initialized to 6.0, that feature flag should return false for isEnabled).

However, as part of this we should audit the use cases of isEnabledAndIgnoreFCVUnsafeAtStartup just to make sure changing them to isEnabledUseLatestFCVWhenUninitialized is correct.



 Comments   
Comment by Githook User [ 15/Nov/23 ]

Author:

{'name': 'Huayu Ouyang', 'email': 'huayu.ouyang@mongodb.com', 'username': 'huayu-ouyang'}

Message: SERVER-82270 Replace isEnabledAndIgnoreFCVUnsafeAtStartup with isEnabledUseLatestFCVWhenUninitialized
Branch: master
https://github.com/mongodb/mongo/commit/5ea2c4928f169b32a6a74969a43c02692b2d2647

Generated at Thu Feb 08 06:48:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.