[SERVER-82347] Remove unnecessary MatchExpression copying from the BitsetTree converter Created: 20/Oct/23  Updated: 29/Oct/23  Resolved: 20/Oct/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.2.0-rc0

Type: Task Priority: Major - P3
Reporter: Alexander Ignatyev Assignee: Alexander Ignatyev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to SERVER-81630 Enable Boolean expression simplifier Closed
Backwards Compatibility: Fully Compatible
Participants:
Linked BF Score: 7

 Description   

The Boolean simplifier stores expressions as std::unique_ptr<MatchExpression>, it does not really need to own the expressions, if we replace the unique pointer by a raw pointer we can avoid unnecessary copying of MatchExpressions.



 Comments   
Comment by Githook User [ 20/Oct/23 ]

Author:

{'name': 'Alexander Ignatyev', 'email': 'alexander.ignatyev@mongodb.com', 'username': 'aligusnet'}

Message: SERVER-82347 Remove unnecessary MatchExpression copying from the BitsetTree converter

Replace the unique pointer in ExpressionBitInfo by a raw pointer to avoid unnecessary copying of MatchExpressions when restoring the expressions from their bitset representation.
Branch: master
https://github.com/mongodb/mongo/commit/76b783238987d735aa49b3ed3e21600a152d9031

Generated at Thu Feb 08 06:48:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.