[SERVER-8240] Convert std::string parameters in auth module to StringData, as appropriate Created: 18/Jan/13  Updated: 08/Jun/18  Resolved: 08/Jun/18

Status: Closed
Project: Core Server
Component/s: Security
Affects Version/s: None
Fix Version/s: 4.1.1

Type: Task Priority: Minor - P4
Reporter: Andy Schwerin Assignee: Kashish Garg
Resolution: Done Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Participants:

 Description   

The auth module takes std::string const& parameters a lot when it could be taking StringData const&. In some places, we have to call StringData::toString() as a result, so when we clean up the parameter types, we'll need to audit callers, too.



 Comments   
Comment by Githook User [ 08/Jun/18 ]

Author:

{'name': 'Kashish Garg', 'email': 'kashish.garg@mongodb.com'}

Message: SERVER-8240 Convert std::string parameters in auth module to StringData, as appropriate
Branch: master
https://github.com/mongodb/mongo/commit/c68e6339eac6228e97f7eb3af7bcac506ce3d9e3

Comment by Githook User [ 08/Jun/18 ]

Author:

{'name': 'Kashish Garg', 'email': 'kashish.garg@mongodb.com'}

Message: SERVER-8240 Convert std::string parameters in auth module to StringData, as appropriate
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/7884e902068eb5ff2c2d7d2525b4622b0e6b853d

Comment by Mark Benvenuto [ 25/May/18 ]

With C++14, we can migrate a lot of string constants from std::string to constexpr StringData.

Generated at Thu Feb 08 03:16:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.