[SERVER-82476] Disable diagnostics latches by default Created: 26/Oct/23  Updated: 01/Feb/24  Resolved: 22/Jan/24

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Amirsaman Memaripour Assignee: Jason Chan
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Problem/Incident
Related
related to SERVER-85594 Enable latch analaysis on build varia... Closed
Assigned Teams:
Service Arch
Backwards Compatibility: Fully Compatible
Backport Requested:
v7.0, v6.0, v5.0, v4.4
Sprint: Service Arch 2023-11-13, Service Arch 2023-11-27, Service Arch 2023-12-11, Service Arch 2023-12-25, Service Arch 2024-01-08, Service Arch 2024-01-22, Service Arch 2024-02-05
Participants:
Linked BF Score: 154

 Description   

Currently one needs to manually disable diagnostics latched by providing an option to the build script: --use-diagnostic-latches=off

This is confusing and error-prone, as the default should be having all non-production features disabled, and requiring users to specify them if needed, rather than manually disable some features to produce the release binaries.



 Comments   
Comment by Githook User [ 23/Jan/24 ]

Author:

{'name': 'Jason Chan', 'email': 'jason.chan@mongodb.com', 'username': 'jasonjhchan'}

Message: SERVER-82476 Enable latches for sanitizer build variants

GitOrigin-RevId: 6d4838e2b412bab5b197088bb0c9cb50c4be2b23
Branch: master
https://github.com/mongodb/mongo/commit/edd552d43283f82cd5ca68d9b5c18edf4860d43d

Comment by Githook User [ 22/Jan/24 ]

Author:

{'name': 'Jason Chan', 'email': 'jason.chan@mongodb.com', 'username': 'jasonjhchan'}

Message: SERVER-82476 Set --use-diagnostic-defaults=off by default (#18239)

GitOrigin-RevId: a2cdad4fb5a2095a1be29ea8bdc8d3247f2bf00f
Branch: master
https://github.com/mongodb/mongo/commit/8de341d0d2011b51eb1d140fb4820424d29fe510

Comment by Githook User [ 20/Jan/24 ]

Author:

{'name': 'Gregory Noma', 'email': 'gregory.noma@gmail.com', 'username': 'gregorynoma'}

Message: Revert "SERVER-82476 Set --use-diagnostic-defaults=off by default"

This reverts commit abe0b372b6ff5854fa465f6b252c751e943a299e.

GitOrigin-RevId: bcb09ff08ab3c9c92c480eb29b1576e345979847
Branch: master
https://github.com/mongodb/mongo/commit/fafd21f1247728dc4245538185f0e0312d71605f

Comment by Githook User [ 19/Jan/24 ]

Author:

{'name': 'Jason Chan', 'email': 'jason.chan@mongodb.com', 'username': 'jasonjhchan'}

Message: SERVER-82476 Set --use-diagnostic-defaults=off by default

GitOrigin-RevId: abe0b372b6ff5854fa465f6b252c751e943a299e
Branch: master
https://github.com/mongodb/mongo/commit/01cbe9c78e162f309ecd9672e38400e9d2d1a69b

Generated at Thu Feb 08 06:49:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.