[SERVER-82599] Parse Optime only once in ReplicationConsistencyMarkersImpl::refreshOplogTruncateAfterPointIfPrimary Created: 30/Oct/23  Updated: 24/Jan/24  Resolved: 03/Jan/24

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Task Priority: Major - P3
Reporter: Mark Benvenuto Assignee: Scott Li
Resolution: Fixed Votes: 0
Labels: perf-8.0, perf-tiger, perf-tiger-handoff, perf-tiger-poc, perf-tiger-q4, repl-shortlist
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Replication
Backwards Compatibility: Fully Compatible
Sprint: Repl 2023-11-27, Repl 2023-12-11, Repl 2023-12-25
Participants:

 Description   

ReplicationConsistencyMarkersImpl::refreshOplogTruncateAfterPointIfPrimary parses the Optime from an oplog entry twice. The code should be change parse it only once. Also, we should take advantage of IDL's ability to disable duplicate field checks.

I have not measured the perf benefits of this change separately.

POC: https://github.com/10gen/mongo/commit/096fabc8c3bc619bfa8b884fc2063f3a8d7cf884#diff-8d3dbd3c29a007065eacb3af7184c7225585b5f0d5d873eeeb981152f207daf0



 Comments   
Comment by Githook User [ 03/Jan/24 ]

Author:

{'name': 'Scott Li', 'email': '146780710+scottli-sz@users.noreply.github.com', 'username': 'scottli-sz'}

Message: SERVER-82599 Parse optime only once when refreshing oplogTruncateAfterPoint (#17724)

GitOrigin-RevId: 8754f32bcb512b975dfaf4ea75b21e4c14ac7b9d
Branch: master
https://github.com/mongodb/mongo/commit/f18348b8d932005c25bc9ef3d718b5e83d984ac3

Generated at Thu Feb 08 06:49:45 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.