[SERVER-82822] Remove Bad Invariant in RetryUntilMajorityCommit Created: 06/Nov/23  Updated: 02/Jan/24  Resolved: 07/Nov/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: 7.2.0-rc0
Fix Version/s: 7.2.1, 7.3.0-rc0

Type: Bug Priority: Major - P3
Reporter: Brett Nawrocki Assignee: Brett Nawrocki
Resolution: Fixed Votes: 0
Labels: sharding-nyc-subteam1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v7.2
Sprint: Cluster Scalability 2023-11-13
Participants:
Linked BF Score: 0

 Description   

RetryUntilMajorityCommit invariants that its CancelToken is not yet cancelled when trying to create its retry helpers. Not only is it technically fine for the token to begin cancelled, it is very possible for this to be the case under expected use, if the PrimaryOnlyService steps down after calling run(), but before initializing the retry helper.



 Comments   
Comment by Githook User [ 02/Jan/24 ]

Author:

{'name': 'Brett Nawrocki', 'email': 'brett.nawrocki@mongodb.com', 'username': 'brettnawrocki'}

Message: SERVER-82822 Remove Bad Invariant in RetryUntilMajorityCommit

(cherry picked from commit 213386fd2a8a41c1fa137aaf0de1adbf037957a5)
Branch: v7.2
https://github.com/mongodb/mongo/commit/938fd79005e9980522bffbaffaac8bed1f004061

Comment by Githook User [ 07/Nov/23 ]

Author:

{'name': 'Brett Nawrocki', 'email': 'brett.nawrocki@mongodb.com', 'username': 'brettnawrocki'}

Message: SERVER-82822 Remove Bad Invariant in RetryUntilMajorityCommit
Branch: master
https://github.com/mongodb/mongo/commit/213386fd2a8a41c1fa137aaf0de1adbf037957a5

Generated at Thu Feb 08 06:50:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.