[SERVER-82859] Config and Shards should not be asserting on the WC of the incoming internal DDL commands Created: 07/Nov/23  Updated: 16/Nov/23

Status: Backlog
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Backlog - Catalog and Routing
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Catalog and Routing
Participants:
Story Points: 2

 Description   

In today's codebase we have code such as this one where the recipient of a command asserts that it contains read/write concern and also there are a lot of sharding DDL commands (such as _shardsvrCreateCollection that assert that the write concern is majority.

These checks are at best a crutch from the past where sharded DDL was executed in the body of the command and we wanted to "make sure we didn't forget to write something with majority". In today's world we have DDL coordinators which are supposed to do the right thing and perform reads and writes with the appropriate concerns.

This ticket is to go through all the places that check for read/write concerns and remove them because they make writing new code difficult since now every command invocation needs to be specialised like this.

Some suggestions for a way to search for these places:


Generated at Thu Feb 08 06:50:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.