[SERVER-82900] Remove variant.h and stdx::variant alias Created: 07/Nov/23 Updated: 05/Dec/23 Resolved: 05/Dec/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.3.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | David Percy | Assignee: | Vinod Kumar |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | techdebt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Service Arch 2023-11-13, Service Arch 2023-11-27, Service Arch 2023-12-11 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
Our ::mongo::stdx::variant type used to be a conditional alias, to support different platforms. But as of Now that ::mongo::stdx::variant and std::variant are always the same, it means code that incorrectly mixes std::variant with ::mongo::stdx::get or vice versa will not be caught in any build variant. So the alias is no longer giving us the benefit of easily switching implementations. Lets remove the alias and find-replace everything to use std::variant directly. |
| Comments |
| Comment by Vinod Kumar [ 05/Dec/23 ] |
|
Switched to std::variant |
| Comment by Githook User [ 03/Dec/23 ] |
|
Author: {'name': 'Vinod Kumar', 'email': 'vinod.kumar@mongodb.com', 'username': 'vkumar-mdb'}Message: GitOrigin-RevId: 2aa03564ad22ec0b4a3517924ec2cec3bfb2e208 |
| Comment by Billy Donahue [ 07/Nov/23 ] |
|
I agree. I think we should either force all code to use the stdx names or force all code to not use it. My preference would be to force all code to not use it. |