[SERVER-83004] Improve tests by using FeatureFlagUtil.isEnabled instead of raw getParamater Created: 09/Nov/23  Updated: 14/Nov/23  Resolved: 14/Nov/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Ivan Fefer Assignee: Ivan Fefer
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-83210 Make featureFlagSbeFull use FCV consi... Closed
Backwards Compatibility: Fully Compatible
Sprint: QE 2023-11-13, QE 2023-11-27
Participants:

 Description   

getParameter command sometime used in jstests to determine if some feature flags are enabled.

Examples:
sbe_util.js

columnstore_util.js

This is incorrect, as getParamater doesn't take into account current FCV: 

feature_flag.cpp

Correct way to check for feature flag status in tests is FeatureFlagUtil.isEnabled()



 Comments   
Comment by Githook User [ 14/Nov/23 ]

Author:

{'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}

Message: SERVER-83004 Use FeatureFlagUtil instead of getParameter in jstests
Branch: master
https://github.com/mongodb/mongo/commit/50f6ffd8c90ac8d3304fbea51e4f0e7486babcd6

Generated at Thu Feb 08 06:50:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.