[SERVER-83161] Fix concurrent read to `_errMsg` from `MigrationDestinationManager` without acquiring mutex Created: 13/Nov/23 Updated: 23/Nov/23 Resolved: 22/Nov/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | 4.4.25, 5.0.22, 6.0.11, 7.0.3, 7.2.0-rc1 |
| Fix Version/s: | 7.3.0-rc0, 7.2.0-rc2, 4.4.27, 7.0.5, 6.0.13, 5.0.24 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Pol Pinol | Assignee: | Aitor Esteve Alvarado |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Backport Requested: |
v7.2, v7.0, v6.0, v5.0, v4.4
|
||||||||
| Sprint: | CAR Team 2023-11-27 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 104 | ||||||||
| Description |
|
An unprotected read access of the variable _errMsg from MigrationDestinationManager at the destructor of MoveTimingHelper, can be concurrent with write accesses, e.g. MigrationDestinationManager::_setStateFail or MigrationDestinationManager::_setStateFailWarn. An implementation idea is to create a copy of the _errMsg protected by the mutex when instantiating a MoveTimingHelper, and not passing an unprotected pointer. |
| Comments |
| Comment by Githook User [ 23/Nov/23 ] |
|
Author: {'name': 'Aitor Esteve Alvarado', 'email': 'aitor.esteve@mongodb.com', 'username': 'atesteve'}Message: (cherry picked from commit a082c2a1393c160d277d62683898ed9fe6dd13fc) GitOrigin-RevId: 39f44bf5d9a88883b0d099e5f3fc98df0d5b1a1f |
| Comment by Githook User [ 23/Nov/23 ] |
|
Author: {'name': 'Aitor Esteve Alvarado', 'email': 'aitor.esteve@mongodb.com', 'username': 'atesteve'}Message: (cherry picked from commit a082c2a1393c160d277d62683898ed9fe6dd13fc) |
| Comment by Githook User [ 23/Nov/23 ] |
|
Author: {'name': 'Aitor Esteve Alvarado', 'email': 'aitor.esteve@mongodb.com', 'username': 'atesteve'}Message: (cherry picked from commit a082c2a1393c160d277d62683898ed9fe6dd13fc) |
| Comment by Githook User [ 23/Nov/23 ] |
|
Author: {'name': 'Aitor Esteve Alvarado', 'email': 'aitor.esteve@mongodb.com', 'username': 'atesteve'}Message: (cherry picked from commit a082c2a1393c160d277d62683898ed9fe6dd13fc) |
| Comment by Githook User [ 22/Nov/23 ] |
|
Author: {'name': 'Aitor Esteve Alvarado', 'email': 'aitor.esteve@mongodb.com', 'username': 'atesteve'}Message: (cherry picked from commit a082c2a1393c160d277d62683898ed9fe6dd13fc) |
| Comment by Githook User [ 22/Nov/23 ] |
|
Author: {'name': 'Aitor Esteve Alvarado', 'email': 'aitor.esteve@mongodb.com', 'username': 'atesteve'}Message: |