[SERVER-83257] IDPManager should make local shared_ptr copies atomically Created: 15/Nov/23  Updated: 06/Dec/23  Resolved: 27/Nov/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0, 7.2.0-rc2, 7.0.5

Type: Bug Priority: Major - P3
Reporter: Spencer Jackson Assignee: Varun Ravichandran
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Assigned Teams:
Server Security
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v7.2, v7.0
Sprint: Security 2023-11-27, Security 2023-12-11
Participants:

 Description   

IDPManager maintains a vector of IDP configurations within a shared_ptr. When it accesses the configurations, it makes a local copy of the shared_ptr so that it can be replaced by other threads. However, the shared_ptr is set atomically, but not read atomically.



 Comments   
Comment by Githook User [ 06/Dec/23 ]

Author:

{'name': 'Varun Ravichandran', 'email': 'varun.ravichandran@mongodb.com', 'username': 'varunravi98'}

Message: SERVER-83257: Use atomic_load for all atomically exchanged shared_ptrs in OIDC subsystems

(cherry picked from commit 939d547f6b6ca1ed8ef477a6b15ca0832cadee98)
(cherry picked from commit 299a153c8bc0727363f0fb3cc9744848d4e958c9)

GitOrigin-RevId: ac2f15f462356574f47edd87dd0c7acbf1a25320
Branch: v7.0
https://github.com/mongodb/mongo/commit/9e55ad1259b4f6a071dc49247b4ba5f33912e767

Comment by Githook User [ 28/Nov/23 ]

Author:

{'name': 'Varun Ravichandran', 'email': 'varun.ravichandran@mongodb.com', 'username': 'varunravi98'}

Message: SERVER-83257: Use atomic_load for all atomically exchanged shared_ptrs in OIDC subsystems

(cherry picked from commit 939d547f6b6ca1ed8ef477a6b15ca0832cadee98)
Branch: v7.2
https://github.com/mongodb/mongo/commit/299a153c8bc0727363f0fb3cc9744848d4e958c9

Comment by Githook User [ 27/Nov/23 ]

Author:

{'name': 'Varun Ravichandran', 'email': 'varun.ravichandran@mongodb.com', 'username': 'varunravi98'}

Message: SERVER-83257: Use atomic_load for all atomically exchanged shared_ptrs in OIDC subsystems
Branch: master
https://github.com/mongodb/mongo/commit/939d547f6b6ca1ed8ef477a6b15ca0832cadee98

Generated at Thu Feb 08 06:51:40 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.