[SERVER-83362] Golden tests pause execution on failure when diff command is interactive Created: 16/Nov/23  Updated: 04/Dec/23

Status: In Code Review
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Anna Wawrzyniak Assignee: Anna Wawrzyniak
Resolution: Unresolved Votes: 0
Labels: auto-reverted
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Operating System: ALL
Participants:
Linked BF Score: 35

 Description   

Golden tests will pause on failure when the executed command happens to be interactive, like default "git diff" on ubuntu.

 

 



 Comments   
Comment by Githook User [ 04/Dec/23 ]

Author:

{'name': 'Anna Wawrzyniak', 'email': '95650737+anna-wawrzyniak@users.noreply.github.com', 'username': 'anna-wawrzyniak'}

Message: SERVER-83362 - Use popen when diffing on failure golden test (#16980)

GitOrigin-RevId: dacdf9523a219486b8f492e02ee97019a6762128
Branch: master
https://github.com/mongodb/mongo/commit/4ea8dfd60ed7bd3b1ee9568153d4f6a70f361d7e

Comment by Githook User [ 29/Nov/23 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com', 'username': ''}

Message: Revert "SERVER-83362 - Use popen when diffing on failure golden test"

This reverts commit 8d30bf7eb3fd9c946fdcaf4090d58b207aee89d0.
Branch: master
https://github.com/mongodb/mongo/commit/dade685d0dcc81c722f617b4bad7513b50e4ed70

Comment by Githook User [ 29/Nov/23 ]

Author:

{'name': 'Anna Wawrzyniak', 'email': 'anna.wawrzyniak@mongodb.com', 'username': 'anna-wawrzyniak'}

Message: SERVER-83362 - Use popen when diffing on failure golden test
Branch: master
https://github.com/mongodb/mongo/commit/8d30bf7eb3fd9c946fdcaf4090d58b207aee89d0

Generated at Thu Feb 08 06:51:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.