[SERVER-8340] Failpoint for recv errors in sock.cpp is injected too late in code path. Created: 25/Jan/13 Updated: 11/Jul/16 Resolved: 13/Feb/13 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | 2.3.2 |
| Fix Version/s: | 2.4.0-rc1 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | triage | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Participants: | |||||||||
| Description |
|
The socket library failpoint for 'recv' does not share a conditional expression with the evaluation of the return value of 'recv': instead, it is currently placed in the error handling function _handleRecvError. This is too late: if the failpoint is enabled, it will only be triggered if 'recv' actually fails, rather than making it appear as if 'recv' failed. The failpoint must be moved earlier, so that it can influence the apparent success or failure of recv. |
| Comments |
| Comment by auto [ 16/Mar/13 ] |
|
Author: {u'date': u'2013-03-11T17:55:42Z', u'name': u'Andrew Morrow', u'email': u'acm@10gen.com'}Message: |
| Comment by auto [ 13/Feb/13 ] |
|
Author: {u'date': u'2013-01-25T18:38:16Z', u'name': u'Andrew Morrow', u'email': u'acm@10gen.com'}Message: |