[SERVER-83466] Make TypeChecker scale when adding signatures for new function call Created: 20/Nov/23  Updated: 21/Nov/23  Resolved: 21/Nov/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Task Priority: Major - P3
Reporter: Alberto Massari Assignee: Alberto Massari
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File perf-test_phase-0008_flamegraph.svg    
Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Sprint: QE 2023-11-27
Participants:
Linked BF Score: 100

 Description   

Profiling shows that the TypeChecker is creating temporary std::strings just to compare the name of the FunctionCall object with the known function names. Using std::string literals or a map would be faster



 Comments   
Comment by Githook User [ 21/Nov/23 ]

Author:

{'name': 'Alberto Massari', 'email': 'alberto.massari@mongodb.com', 'username': 'albymassari'}

Message: SERVER-83466 Avoid creation of temporary std::string objects
Branch: master
https://github.com/mongodb/mongo/commit/7b74fccde48dbbe45c83a87686b6a73f516e5c04

Generated at Thu Feb 08 06:52:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.