[SERVER-83490] Don't execute $addFields in SBE when it is part of $setWindowFields Created: 21/Nov/23 Updated: 29/Nov/23 Resolved: 27/Nov/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.3.0-rc0, 7.2.0-rc2 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Foteini Alvanaki | Assignee: | Foteini Alvanaki |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Backport Requested: |
v7.2
|
||||||||||||
| Sprint: | QE 2023-11-27, QE 2023-12-11 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 120 | ||||||||||||
| Description |
|
Executing in SBE $addFields that is part of a $setWindowFields gives a regression in the default variant that executes $setWindowsField in classic. To mitigate this issue we will not push in SBE `$addFields` that is part of `$setWindowFields` until `$setWindowFields` has been pushed in SBE and the performance regression has been fixed.
|
| Comments |
| Comment by Githook User [ 24/Nov/23 ] |
|
Author: {'name': 'Foteini Alvanaki', 'email': 'foteini.alvanaki@mongodb.com', 'username': ''}Message: |
| Comment by Githook User [ 24/Nov/23 ] |
|
Author: {'name': 'Foteini Alvanaki', 'email': 'foteini.alvanaki@mongodb.com', 'username': ''}Message: |
| Comment by Githook User [ 24/Nov/23 ] |
|
Author: {'name': 'Foteini Alvanaki', 'email': 'foteini.alvanaki@mongodb.com', 'username': ''}Message: Revert " This reverts commit b39883a2c9fc05cad5e8993f8c0dd712b91d270a. |
| Comment by Githook User [ 24/Nov/23 ] |
|
Author: {'name': 'Foteini Alvanaki', 'email': 'foteini.alvanaki@mongodb.com', 'username': ''}Message: Revert " This reverts commit 99353dfe36d1504d6fd123f279161fd21b332890. |
| Comment by Foteini Alvanaki [ 23/Nov/23 ] |
|
The change did not consider the feature flag and disables pushing to SBE $addField that has been created during desugaring $setWindowFields even when sbeFull flag has been set. I am reverting the change since this essentially disables pushing setWindowFields almost completely.
|
| Comment by Githook User [ 23/Nov/23 ] |
|
Author: {'name': 'Foteini Alvanaki', 'email': 'foteini.alvanaki@mongodb.com', 'username': ''}Message: |
| Comment by Githook User [ 23/Nov/23 ] |
|
Author: {'name': 'Foteini Alvanaki', 'email': 'foteini.alvanaki@mongodb.com', 'username': ''}Message: |