[SERVER-83511] Set cluster role before creating oplog in RollbackImplTest Created: 21/Nov/23  Updated: 21/Dec/23  Resolved: 21/Dec/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Samyukta Lanka Assignee: Samyukta Lanka
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Operating System: ALL
Sprint: Repl 2023-11-27, Repl 2023-12-11, Repl 2023-12-25
Participants:
Linked BF Score: 139

 Description   

We set the cluster role in the test fixture after we initiate the oplog visibility thread by creating the oplog, which can cause a data race.



 Comments   
Comment by Samyukta Lanka [ 21/Dec/23 ]

Closing in favor of SERVER-84365.

Comment by Githook User [ 21/Dec/23 ]

Author:

{'name': 'Samy Lanka', 'email': 'samy.lanka@mongodb.com', 'username': 'lankas'}

Message: Revert "SERVER-83511 Set cluster role before creating oplog in RollbackImplTest (#17662)"

This reverts commit 4791d0d8841af0245c512ab9d9a8c17da911854a.

GitOrigin-RevId: 9efe6fb6bec1afbe83b2d0e0bd23d4f73babc889
Branch: master
https://github.com/mongodb/mongo/commit/2368f26caa2765959b6aa556cac19254eca7fe9d

Comment by Githook User [ 20/Dec/23 ]

Author:

{'name': 'Samy Lanka', 'email': 'samy.lanka@mongodb.com', 'username': 'lankas'}

Message: SERVER-83511 Set cluster role before creating oplog in RollbackImplTest (#17662)

GitOrigin-RevId: 4791d0d8841af0245c512ab9d9a8c17da911854a
Branch: master
https://github.com/mongodb/mongo/commit/6bd9b3e88d2d7cb248d3a4b050a0660f2fe3be1f

Comment by Samyukta Lanka [ 08/Dec/23 ]

Another option is to change what additional threads we startup with the unit test, like the journal flusher and oplog visibility threads

Comment by Samyukta Lanka [ 01/Dec/23 ]

This is also a race in some of the unit tests that manually specify the cluster role. Either we need to create the oplog within each unit test, or we should suppress TSAN warnings about this. In theory we could create a new test fixture for these types of tests, but I think that comes with too much overhead and isn't worth the extra code for people to understand.

Generated at Thu Feb 08 06:52:24 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.