[SERVER-83511] Set cluster role before creating oplog in RollbackImplTest Created: 21/Nov/23 Updated: 21/Dec/23 Resolved: 21/Dec/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Samyukta Lanka | Assignee: | Samyukta Lanka |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Operating System: | ALL | ||||
| Sprint: | Repl 2023-11-27, Repl 2023-12-11, Repl 2023-12-25 | ||||
| Participants: | |||||
| Linked BF Score: | 139 | ||||
| Description |
|
We set the cluster role in the test fixture after we initiate the oplog visibility thread by creating the oplog, which can cause a data race. |
| Comments |
| Comment by Samyukta Lanka [ 21/Dec/23 ] |
|
Closing in favor of |
| Comment by Githook User [ 21/Dec/23 ] |
|
Author: {'name': 'Samy Lanka', 'email': 'samy.lanka@mongodb.com', 'username': 'lankas'}Message: Revert " This reverts commit 4791d0d8841af0245c512ab9d9a8c17da911854a. GitOrigin-RevId: 9efe6fb6bec1afbe83b2d0e0bd23d4f73babc889 |
| Comment by Githook User [ 20/Dec/23 ] |
|
Author: {'name': 'Samy Lanka', 'email': 'samy.lanka@mongodb.com', 'username': 'lankas'}Message: GitOrigin-RevId: 4791d0d8841af0245c512ab9d9a8c17da911854a |
| Comment by Samyukta Lanka [ 08/Dec/23 ] |
|
Another option is to change what additional threads we startup with the unit test, like the journal flusher and oplog visibility threads |
| Comment by Samyukta Lanka [ 01/Dec/23 ] |
|
This is also a race in some of the unit tests that manually specify the cluster role. Either we need to create the oplog within each unit test, or we should suppress TSAN warnings about this. In theory we could create a new test fixture for these types of tests, but I think that comes with too much overhead and isn't worth the extra code for people to understand. |