[SERVER-83659] updateArrayFilters is incremented twice on timeseries retryable write Created: 28/Nov/23 Updated: 05/Dec/23 Resolved: 05/Dec/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.3.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Frederic Vitzikam | Assignee: | Yuhong Zhang |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Storage Execution
|
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Execution Team 2023-12-11 |
| Participants: |
| Description |
|
Running the following once increases updateArrayFilters by 2 in serverStatus.metrics.update:
I think it is because this code means we go into this twice. Maybe the incrementUpdateMetrics loop should be in a if(!isTimeseriesViewRequest || !opCtx->isRetryableWrite() || !opCtx->inMultiDocumentTransaction()) or similar ? I added a TODO for this in a bulk_write js test comparing those metrics between bulkWrite and non-bulkWrite. |
| Comments |
| Comment by Githook User [ 05/Dec/23 ] |
|
Author: {'name': 'Yuhong Zhang', 'email': 'yuhong.zhang@mongodb.com', 'username': 'YuhongZhang98'}Message: GitOrigin-RevId: ff3d89d9de85f945da57d44ae0461eb09cfd6a1c |