[SERVER-83938] MigrationChunkClonerSource::_checkRecipientCloningStatus tries to access null _sessionCatalogSoure Created: 06/Dec/23  Updated: 08/Dec/23

Status: In Code Review
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Randolph Tan Assignee: Randolph Tan
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Operating System: ALL
Participants:
Linked BF Score: 14

 Description   

https://github.com/10gen/mongo/blob/f314b9690b1677033e17b0b2f56590c2f29636b4/src/mongo/db/s/migration_chunk_cloner_source.cpp#L1212

 _sessionCatalogSoure is currently only initialized when mode is in repl set. Since we are going to make repl set enabled all the time we can probably get rid of the conditional initialization. For older branches, we should add if condition to check if it is null like the rest of the code.



 Comments   
Comment by Randolph Tan [ 06/Dec/23 ]

It looks like we have been requiring shards to be repl sets since v3.6 according to the docs. So we should probably change init to always happen and assert that it's a repl set at the beginning.

Generated at Thu Feb 08 06:53:35 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.