[SERVER-84064] Consider removing _isCancelled calls in read/write for gRPC sessions Created: 11/Dec/23 Updated: 12/Dec/23 |
|
| Status: | Needs Scheduling |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Erin McNulty | Assignee: | Backlog - Service Architecture |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Service Arch
|
| Participants: |
| Description |
|
Calling _isCancelled in gRPC actually requires a pop off of the gRPC completion queue (aka a synchronization). When I removed it from calls to source and sink Message in grpcSession, I saw improvements of about ~70ms in local benchrun testing for a findOne. Consider removing this call/reconsidering this implementation. |