[SERVER-84110] Narrow the filtering of PrimaryOnlyServiceOpObserver for deletes Created: 12/Dec/23  Updated: 19/Jan/24  Resolved: 11/Jan/24

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Matt Kneiser Assignee: Matt Kneiser
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-77364 Speed up OpObservers with a filter fr... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2023-12-25, Execution Team 2024-01-08, Execution Team 2024-01-22
Participants:

 Description   

As found by suganthi.mani@mongodb.com, this OpObserver is not filtering on namespaces for deletes at the moment (i.e. it is set to kAll).

 

The implicit filtering is dependent on:
PrimaryOnlyServiceRegistry::lookupServerByNamespace() only has services registered that have getStateDocumentsNS() that pertain to the config db. Here is the full list of currently overridden methods, all of which are within the config db.

  • kShardMergeRecipientsNamespace
  • kTenantMigrationDonorsNamespace
  • kTenantMigrationRecipientsNamespace
  • kConfigsvrCoordinatorsNamespace
  • kGlobalIndexClonerNamespace
  • kMultiUpdateCoordinatorsNamespace
  • kShardingRenameParticipantsNamespace
  • kConfigReshardingOperationsNamespace
  • kDonorReshardingOperationsNamespace
  • kRecipientReshardingOperationsNamespace
  • kShardingDDLCoordinatorsNamespace
  • kShardSplitDonorsNamespace
  • kSetChangeStreamStateCoordinatorNamespace


 Comments   
Comment by Githook User [ 11/Jan/24 ]

Author:

{'name': 'Matt Kneiser', 'email': 'matt.kneiser@mongodb.com', 'username': 'themattman'}

Message: SERVER-84110 Only run PrimaryOnlyServiceOpObserver on ConfigDB for deletes (#17541)

GitOrigin-RevId: c6d7079f8f69485b9430e792d06bb4781e75056c
Branch: master
https://github.com/mongodb/mongo/commit/8f893a3d1fae5c2fd69fb14b401c1c9e30c99531

Generated at Thu Feb 08 06:54:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.